Fix v0.x.x #102
Merged
Fix v0.x.x #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be added in a backwards-compatible way, so we can add it to the top-level. Signed-off-by: Leandro Lucarella <[email protected]>
We can add the new name for electrical components keeping backwards compatibility without the need for a new namespace, so we just move it to the top-level `microgrid` package. Signed-off-by: Leandro Lucarella <[email protected]>
We don't need this namespace in this repository, this is useful for API repositories (protobuf), but for Python we can keep backwards compatibility in a different way. Signed-off-by: Leandro Lucarella <[email protected]>
We want to be compatible up to v1.0.0, not v9.0.0. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
github-actions
bot
added
part:docs
There was a problem hiding this comment.
Pull Request Overview
This PR fixes v0.x.x by removing the v1alpha8 namespace and making new additions backwards compatible. It moves modules from v1alpha8 to top-level and fixes dependency constraints.
- Removes entire v1alpha8 namespace and moves components to top-level modules
- Updates imports from v1alpha8 to new locations (electrical_components and streaming)
- Fixes dependency constraint for frequenz-api-common from "< 9" to "< 1"
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_streaming.py | Updates import and docstring to reference top-level streaming module |
| tests/test_client_common_v1alpha8.py | Removes entire test file for v1alpha8 components |
| tests/microgrid/test_ids_alpha8.py | Removes entire test file for v1alpha8 microgrid IDs |
| src/frequenz/client/common/v1alpha8/* | Removes all v1alpha8 modules including pagination, microgrid, sensors, metric, and init.py |
| pyproject.toml | Updates frequenz-api-common dependency constraint from "< 9" to "< 1" |
| RELEASE_NOTES.md | Updates release notes to reflect backwards compatible changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Marenz
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes v0.x.x by removing the recently introduced
v1alpha8namespace and making the new additions backwards compatible.It moves the new additions from the
v1alpha8namespace to the top-level (electrical_componentsandstreamingmodulues). It also fixes the dependency constraint forfrequenz-api-common.